octeontx2-af: returning uninitialized variable
authorSebin Sebastian <mailmesebin00@gmail.com>
Wed, 13 Jul 2022 07:38:58 +0000 (13:08 +0530)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Jul 2022 13:51:34 +0000 (14:51 +0100)
Fix coverity error 'use of uninitialized variable'. err is uninitialized
and is returned which can lead to unintended results. err has been replaced
with -einval.
Coverity issue: 1518921 (uninitialized scalar variable)

Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c

index ff71e6a..1195b69 100644 (file)
@@ -1959,7 +1959,7 @@ int rvu_npc_exact_init(struct rvu *rvu)
                        dev_err(rvu->dev,
                                "%s: failed to set drop info for cgx=%d, lmac=%d, chan=%llx\n",
                                __func__, cgx_id, lmac_id, chan_val);
-                       return err;
+                       return -EINVAL;
                }
 
                err = npc_install_mcam_drop_rule(rvu, *drop_mcam_idx,