hwrng: nomadik - use dev_err_probe
authorMartin Kaiser <martin@kaiser.cx>
Sun, 2 Jul 2023 17:35:03 +0000 (19:35 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 20 Jul 2023 10:16:23 +0000 (22:16 +1200)
Use dev_err_probe to print a message and return an error. This makes the
code a tiny bit shorter.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/nomadik-rng.c

index 3774adf..8c6a40d 100644 (file)
@@ -39,11 +39,8 @@ static int nmk_rng_probe(struct amba_device *dev, const struct amba_id *id)
        int ret;
 
        rng_clk = devm_clk_get_enabled(&dev->dev, NULL);
-       if (IS_ERR(rng_clk)) {
-               dev_err(&dev->dev, "could not get rng clock\n");
-               ret = PTR_ERR(rng_clk);
-               return ret;
-       }
+       if (IS_ERR(rng_clk))
+               return dev_err_probe(&dev->dev, PTR_ERR(rng_clk), "could not get rng clock\n");
 
        ret = amba_request_regions(dev, dev->dev.init_name);
        if (ret)