usb: fotg210-udc: remove redundant error logging
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Jan 2023 15:44:35 +0000 (17:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jan 2023 17:12:58 +0000 (18:12 +0100)
A call to platform_get_irq() already prints an error on failure within
its own implementation. So printing another error based on its return
value in the caller is redundant and should be removed. The clean up
also makes if condition block braces unnecessary. Remove that as well.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230120154437.22025-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/fotg210/fotg210-udc.c

index ae29787..21f3112 100644 (file)
@@ -1180,10 +1180,8 @@ int fotg210_udc_probe(struct platform_device *pdev, struct fotg210 *fotg)
        int i;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               pr_err("could not get irq\n");
-               return -ENODEV;
-       }
+       if (irq < 0)
+               return irq;
 
        /* initialize udc */
        fotg210 = kzalloc(sizeof(struct fotg210_udc), GFP_KERNEL);