btrfs: make btrfs_sysfs_remove_devices_dir return void
authorAnand Jain <anand.jain@oracle.com>
Fri, 4 Sep 2020 17:34:25 +0000 (01:34 +0800)
committerDavid Sterba <dsterba@suse.com>
Wed, 7 Oct 2020 10:12:21 +0000 (12:12 +0200)
btrfs_sysfs_remove_devices_dir() return value is unused declare it as
void.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/sysfs.c
fs/btrfs/sysfs.h

index a3bd4ba..66fbb82 100644 (file)
@@ -1213,18 +1213,16 @@ static void btrfs_sysfs_remove_device(struct btrfs_device *device)
 }
 
 /* When @device is NULL, remove all devices link */
-int btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices,
-                                  struct btrfs_device *device)
+void btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices,
+                                   struct btrfs_device *device)
 {
        if (device) {
                btrfs_sysfs_remove_device(device);
-               return 0;
+               return;
        }
 
        list_for_each_entry(device, &fs_devices->devices, dev_list)
                btrfs_sysfs_remove_device(device);
-
-       return 0;
 }
 
 static ssize_t btrfs_devinfo_in_fs_metadata_show(struct kobject *kobj,
index 4217823..1431dbc 100644 (file)
@@ -16,8 +16,8 @@ char *btrfs_printable_features(enum btrfs_feature_set set, u64 flags);
 const char *btrfs_feature_set_name(enum btrfs_feature_set set);
 int btrfs_sysfs_add_devices_dir(struct btrfs_fs_devices *fs_devices,
                struct btrfs_device *one_device);
-int btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices,
-                struct btrfs_device *one_device);
+void btrfs_sysfs_remove_devices_dir(struct btrfs_fs_devices *fs_devices,
+                                   struct btrfs_device *device);
 int btrfs_sysfs_add_fsid(struct btrfs_fs_devices *fs_devs);
 void btrfs_sysfs_remove_fsid(struct btrfs_fs_devices *fs_devs);
 void btrfs_sysfs_update_sprout_fsid(struct btrfs_fs_devices *fs_devices);