hippi: Remove call to memset after pci_alloc_consistent
authorFuqian Huang <huangfq.daxian@gmail.com>
Mon, 15 Jul 2019 03:19:21 +0000 (11:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Jul 2019 18:06:27 +0000 (11:06 -0700)
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hippi/rrunner.c

index 7b9350d..2a6ec53 100644 (file)
@@ -1196,7 +1196,6 @@ static int rr_open(struct net_device *dev)
                goto error;
        }
        rrpriv->rx_ctrl_dma = dma_addr;
-       memset(rrpriv->rx_ctrl, 0, 256*sizeof(struct ring_ctrl));
 
        rrpriv->info = pci_alloc_consistent(pdev, sizeof(struct rr_info),
                                            &dma_addr);
@@ -1205,7 +1204,6 @@ static int rr_open(struct net_device *dev)
                goto error;
        }
        rrpriv->info_dma = dma_addr;
-       memset(rrpriv->info, 0, sizeof(struct rr_info));
        wmb();
 
        spin_lock_irqsave(&rrpriv->lock, flags);