util/xmlconfig: Disable for Windows like Android
authorJames Park <jpark37@lagfreegames.com>
Fri, 7 Aug 2020 02:48:39 +0000 (19:48 -0700)
committerMarge Bot <eric+marge@anholt.net>
Sun, 25 Oct 2020 03:04:09 +0000 (03:04 +0000)
The code does not compile on Windows, so just disable for now. There is
already a pattern to do this for Android.

Stop including expat dependency if building Windows.

Disable WITH_XMLCONFIG if _WIN32 is defined.

Tuck _WIN32 incompatible includes inside WITH_XMLCONFIG.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7249>

src/util/meson.build
src/util/xmlconfig.c

index f38b725..a820675 100644 (file)
@@ -200,7 +200,7 @@ idep_mesautil = declare_dependency(
 )
 
 xmlconfig_deps = []
-if not with_platform_android
+if not (with_platform_android or with_platform_windows)
   xmlconfig_deps += dep_expat
 endif
 
index 4bd5339..0245f8f 100644 (file)
@@ -27,7 +27,7 @@
  * \author Felix Kuehling
  */
 
-#ifdef ANDROID
+#if defined(ANDROID) || defined(_WIN32)
 #define WITH_XMLCONFIG 0
 #else
 #define WITH_XMLCONFIG 1
 #include <assert.h>
 #if WITH_XMLCONFIG
 #include <expat.h>
-#endif
-#include <fcntl.h>
-#include <math.h>
 #include <unistd.h>
 #include <errno.h>
 #include <dirent.h>
 #include <sys/stat.h>
 #include <regex.h>
+#endif
+#include <fcntl.h>
+#include <math.h>
 #include "strndup.h"
 #include "xmlconfig.h"
 #include "u_process.h"