loop: fix order of cleaning up the queue and freeing the tagset

We must release the queue before freeing the tagset.

Fixes: 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")
Reported-by: Bruno Goncalves <bgoncalv@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 3f40e673a101ace10e1e6a5e9e3996ecdb623380..e90f7d349816e85c652e9912982cb2612db35966 100644 (file)
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -2183,8 +2183,8 @@ out:
 static void loop_remove(struct loop_device *lo)
 {
        del_gendisk(lo->lo_disk);
-       blk_mq_free_tag_set(&lo->tag_set);
        blk_cleanup_disk(lo->lo_disk);
+       blk_mq_free_tag_set(&lo->tag_set);
        mutex_destroy(&lo->lo_mutex);
        kfree(lo);
 }