habanalabs: get lower/upper 32 bits via masking
authorKoby Elbaz <kelbaz@habana.ai>
Thu, 17 Jun 2021 14:04:16 +0000 (17:04 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 21 Jun 2021 07:16:29 +0000 (10:16 +0300)
fix multiple similar occurrences of the following sparse warning:
'warning: cast truncates bits from constant value
(7ffc113000 becomes fc113000)'

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/gaudi/gaudi.c
drivers/misc/habanalabs/goya/goya.c

index be83094..4a75df2 100644 (file)
@@ -3858,7 +3858,7 @@ static void gaudi_init_static_firmware_loader(struct hl_device *hdev)
        static_loader->boot_err1_reg = mmCPU_BOOT_ERR1;
        static_loader->preboot_version_offset_reg = mmPREBOOT_VER_OFFSET;
        static_loader->boot_fit_version_offset_reg = mmUBOOT_VER_OFFSET;
-       static_loader->sram_offset_mask = ~((u32)SRAM_BASE_ADDR);
+       static_loader->sram_offset_mask = ~(lower_32_bits(SRAM_BASE_ADDR));
 }
 
 static void gaudi_init_firmware_loader(struct hl_device *hdev)
index 06f5f14..755e08c 100644 (file)
@@ -2484,7 +2484,7 @@ static void goya_init_static_firmware_loader(struct hl_device *hdev)
        static_loader->boot_err1_reg = mmCPU_BOOT_ERR1;
        static_loader->preboot_version_offset_reg = mmPREBOOT_VER_OFFSET;
        static_loader->boot_fit_version_offset_reg = mmUBOOT_VER_OFFSET;
-       static_loader->sram_offset_mask = ~((u32)SRAM_BASE_ADDR);
+       static_loader->sram_offset_mask = ~(lower_32_bits(SRAM_BASE_ADDR));
 }
 
 static void goya_init_firmware_loader(struct hl_device *hdev)