io_uring: fix compile warning for 32-bit builds
authorJens Axboe <axboe@kernel.dk>
Mon, 25 Apr 2022 22:43:45 +0000 (16:43 -0600)
committerJens Axboe <axboe@kernel.dk>
Mon, 25 Apr 2022 22:43:45 +0000 (16:43 -0600)
If IO_URING_SCM_ALL isn't set, as it would not be on 32-bit builds,
then we trigger a warning:

fs/io_uring.c: In function '__io_sqe_files_unregister':
fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
 8992 |         int i;
      |             ^

Move the ifdef up to include the 'i' variable declaration.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 5e45690a1cb8 ("io_uring: store SCM state in io_fixed_file->file_ptr")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index e57d47a23682fdb25dc4f7fef08bd555dbc6b8f7..b40b640924dba8eabbef4bc14567a93fac6befcc 100644 (file)
@@ -8667,9 +8667,9 @@ static void io_free_file_tables(struct io_file_table *table)
 
 static void __io_sqe_files_unregister(struct io_ring_ctx *ctx)
 {
+#if !defined(IO_URING_SCM_ALL)
        int i;
 
-#if !defined(IO_URING_SCM_ALL)
        for (i = 0; i < ctx->nr_user_files; i++) {
                struct file *file = io_file_from_index(ctx, i);