perf annotate: Remove redundant 'ret' variable
authortangmeng <tangmeng@uniontech.com>
Wed, 16 Feb 2022 03:04:24 +0000 (11:04 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 16 Feb 2022 13:38:55 +0000 (10:38 -0300)
Return the result from hist_entry_iter__add() directly instead of taking
this in another redundant variable.

Signed-off-by: tangmeng <tangmeng@uniontech.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220216030425.27779-1-tangmeng@uniontech.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-annotate.c

index 5e038d9..e65dc38 100644 (file)
@@ -194,7 +194,6 @@ static int process_branch_callback(struct evsel *evsel,
        };
 
        struct addr_location a;
-       int ret;
 
        if (machine__resolve(machine, &a, sample) < 0)
                return -1;
@@ -207,8 +206,7 @@ static int process_branch_callback(struct evsel *evsel,
 
        hist__account_cycles(sample->branch_stack, al, sample, false, NULL);
 
-       ret = hist_entry_iter__add(&iter, &a, PERF_MAX_STACK_DEPTH, ann);
-       return ret;
+       return hist_entry_iter__add(&iter, &a, PERF_MAX_STACK_DEPTH, ann);
 }
 
 static bool has_annotation(struct perf_annotate *ann)