usb: gadget: f_fs: Fix ExtCompat descriptor validation 90/218590/1
authorVincent Pelletier <plr.vincent@gmail.com>
Thu, 15 Dec 2016 12:47:42 +0000 (12:47 +0000)
committerDongwoo Lee <dwoo08.lee@samsung.com>
Tue, 26 Nov 2019 02:22:07 +0000 (11:22 +0900)
[ Upstream commit 354bc45bf329494ef6051f3229ef50b9e2a7ea2a ]

Reserved1 is documented as expected to be set to 0, but this test fails
when it it set to 0. Reverse the condition.

Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[dwoo08.lee: cherry-pick linux-4.9.y stable commit 5eb97be87981 to stablize f_fs]
Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
Change-Id: Id8bd89a9cb5343fd0830d480ad5b2900367d8056

drivers/usb/gadget/function/f_fs.c

index d084335c834674fe39ef98697b359aee4124e37c..2d3d22c837b2bfd59878b4fc9a10596d4ba5058c 100644 (file)
@@ -2264,7 +2264,7 @@ static int __ffs_data_do_os_desc(enum ffs_os_desc_type type,
 
                if (len < sizeof(*d) ||
                    d->bFirstInterfaceNumber >= ffs->interfaces_count ||
-                   !d->Reserved1)
+                   d->Reserved1)
                        return -EINVAL;
                for (i = 0; i < ARRAY_SIZE(d->Reserved2); ++i)
                        if (d->Reserved2[i])