gpio: dwapb: Discard ACPI GPIO-chip IRQs request
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Thu, 30 Jul 2020 15:28:04 +0000 (18:28 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 27 Aug 2020 08:32:58 +0000 (10:32 +0200)
Since GPIOlib-based IRQ-chip interface is now utilized there is no need
in calling the methods acpi_gpiochip_{request,free}_interrupts() here.
They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove()
anyway.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200730152808.2955-8-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-dwapb.c

index b6affe7..707e908 100644 (file)
@@ -526,9 +526,6 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
                return err;
        }
 
-       /* Add GPIO-signaled ACPI event support */
-       acpi_gpiochip_request_interrupts(&port->gc);
-
        port->is_registered = true;
 
        return 0;
@@ -544,7 +541,6 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
                if (!port->is_registered)
                        continue;
 
-               acpi_gpiochip_free_interrupts(&port->gc);
                gpiochip_remove(&port->gc);
        }
 }