ac/nir: assert printfs will fit
authorJames Legg <jlegg@feralinteractive.com>
Fri, 23 Jun 2017 10:18:57 +0000 (11:18 +0100)
committerBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Wed, 28 Jun 2017 19:05:04 +0000 (21:05 +0200)
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/common/ac_nir_to_llvm.c

index b5c6848..a02968e 100644 (file)
@@ -1133,7 +1133,9 @@ static LLVMValueRef emit_intrin_1f_param(struct ac_llvm_context *ctx,
                to_float(ctx, src0),
        };
 
-       sprintf(name, "%s.f%d", intrin, get_elem_bits(ctx, result_type));
+       MAYBE_UNUSED const int length = snprintf(name, sizeof(name), "%s.f%d", intrin,
+                                                get_elem_bits(ctx, result_type));
+       assert(length < sizeof(name));
        return ac_build_intrinsic(ctx, name, result_type, params, 1, AC_FUNC_ATTR_READNONE);
 }
 
@@ -1148,7 +1150,9 @@ static LLVMValueRef emit_intrin_2f_param(struct ac_llvm_context *ctx,
                to_float(ctx, src1),
        };
 
-       sprintf(name, "%s.f%d", intrin, get_elem_bits(ctx, result_type));
+       MAYBE_UNUSED const int length = snprintf(name, sizeof(name), "%s.f%d", intrin,
+                                                get_elem_bits(ctx, result_type));
+       assert(length < sizeof(name));
        return ac_build_intrinsic(ctx, name, result_type, params, 2, AC_FUNC_ATTR_READNONE);
 }
 
@@ -1164,7 +1168,9 @@ static LLVMValueRef emit_intrin_3f_param(struct ac_llvm_context *ctx,
                to_float(ctx, src2),
        };
 
-       sprintf(name, "%s.f%d", intrin, get_elem_bits(ctx, result_type));
+       MAYBE_UNUSED const int length = snprintf(name, sizeof(name), "%s.f%d", intrin,
+                                                get_elem_bits(ctx, result_type));
+       assert(length < sizeof(name));
        return ac_build_intrinsic(ctx, name, result_type, params, 3, AC_FUNC_ATTR_READNONE);
 }
 
@@ -3456,8 +3462,9 @@ static LLVMValueRef visit_image_atomic(struct nir_to_llvm_context *ctx,
        build_int_type_name(LLVMTypeOf(coords),
                            coords_type, sizeof(coords_type));
 
-       snprintf(intrinsic_name, sizeof(intrinsic_name),
-                        "%s.%s.%s", base_name, atomic_name, coords_type);
+       MAYBE_UNUSED const int length = snprintf(intrinsic_name, sizeof(intrinsic_name),
+                                                "%s.%s.%s", base_name, atomic_name, coords_type);
+       assert(length < sizeof(intrinsic_name));
        return ac_build_intrinsic(&ctx->ac, intrinsic_name, ctx->i32, params, param_count, 0);
 }