of: reserved-memory: Print allocation/reservation failures as error
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Tue, 28 Jun 2022 11:35:40 +0000 (13:35 +0200)
committerRob Herring <robh@kernel.org>
Tue, 28 Jun 2022 20:15:36 +0000 (14:15 -0600)
If the allocation/reservation of reserved-memory fails, it is normally
an error, so print it as an error so that it doesn't get hidden from the
console due to the loglevel.  Also make the allocation failure include
the size just like the reservation failure.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220628113540.2790835-1-vincent.whitchurch@axis.com
drivers/of/fdt.c
drivers/of/of_reserved_mem.c

index a8f5b65..4610729 100644 (file)
@@ -532,8 +532,8 @@ static int __init __reserved_mem_reserve_reg(unsigned long node,
                                kmemleak_alloc_phys(base, size, 0, 0);
                }
                else
-                       pr_info("Reserved memory: failed to reserve memory for node '%s': base %pa, size %lu MiB\n",
-                               uname, &base, (unsigned long)(size / SZ_1M));
+                       pr_err("Reserved memory: failed to reserve memory for node '%s': base %pa, size %lu MiB\n",
+                              uname, &base, (unsigned long)(size / SZ_1M));
 
                len -= t_len;
                if (first) {
index 75caa6f..65f3b02 100644 (file)
@@ -156,7 +156,8 @@ static int __init __reserved_mem_alloc_size(unsigned long node,
        }
 
        if (base == 0) {
-               pr_info("failed to allocate memory for node '%s'\n", uname);
+               pr_err("failed to allocate memory for node '%s': size %lu MiB\n",
+                      uname, (unsigned long)(size / SZ_1M));
                return -ENOMEM;
        }