meson: Use run_command check: true for windows binary subprojects
authorNirbheek Chauhan <nirbheek@centricular.com>
Wed, 19 Oct 2022 03:52:21 +0000 (09:22 +0530)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 19 Oct 2022 04:05:05 +0000 (04:05 +0000)
Fixes a warning about using the check kwarg

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3224>

subprojects/win-flex-bison-binaries/meson.build
subprojects/win-nasm/meson.build

index 7b08888..f43f39a 100644 (file)
@@ -6,11 +6,7 @@ message('Downloading and extracting win-flex-bison binaries...')
 
 zip_hash = '8d324b62be33604b2c45ad1dd34ab93d722534448f55a16ca7292de32b6ac135'
 
-ret = run_command(py3, files('download-binary.py'), meson.project_version(), zip_hash)
-if ret.returncode() != 0
-  message(ret.stdout())
-  error(ret.stderr())
-endif
+ret = run_command(py3, files('download-binary.py'), meson.project_version(), zip_hash, check: true)
 
 meson.override_find_program('flex', find_program('win_flex'))
 meson.override_find_program('bison', find_program('win_bison'))
index c5c9000..ee3bfb8 100644 (file)
@@ -15,10 +15,6 @@ else
   zip_hash = '2b8a00d9fa348e7b68bac0497e25be44db83c64d6681478fdcbfa03fca36ad76'
 endif
 
-ret = run_command(py3, files('download-binary.py'), meson.project_version(), arch, zip_hash)
-if ret.returncode() != 0
-  message(ret.stdout())
-  error(ret.stderr())
-endif
+ret = run_command(py3, files('download-binary.py'), meson.project_version(), arch, zip_hash, check: true)
 
 meson.override_find_program('nasm', find_program(join_paths('nasm-@0@'.format(meson.project_version()), 'nasm')))