watchdog: ftwdt010_wdt: fix test for platform_get_irq() failure
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 11 Aug 2022 10:56:06 +0000 (13:56 +0300)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 2 Oct 2022 10:55:36 +0000 (12:55 +0200)
This code assumes that platform_get_irq() function returns zero on
failure.  In fact, platform_get_irq() never returns zero.  It returns
negative error codes or positive non-zero values on success.

Fixes: eca10ae6000d ("watchdog: add driver for Cortina Gemini watchdog")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/YvTgRk/ABp62/hNA@kili
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/ftwdt010_wdt.c

index 0a5bbfd..442c5bf 100644 (file)
@@ -171,7 +171,7 @@ static int ftwdt010_wdt_probe(struct platform_device *pdev)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq) {
+       if (irq > 0) {
                ret = devm_request_irq(dev, irq, ftwdt010_wdt_interrupt, 0,
                                       "watchdog bark", gwdt);
                if (ret)