spi: spi-tegra20-sflash: remove redundant irqsave and irqrestore in hardIRQ
authorBarry Song <song.bao.hua@hisilicon.com>
Sat, 26 Sep 2020 00:16:15 +0000 (12:16 +1200)
committerMark Brown <broonie@kernel.org>
Thu, 1 Oct 2020 22:45:27 +0000 (23:45 +0100)
Running in hardIRQ, disabling IRQ is redundant.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200926001616.21292-1-song.bao.hua@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra20-sflash.c

index 02cf5f4..b59015c 100644 (file)
@@ -359,9 +359,8 @@ exit:
 static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd)
 {
        struct spi_transfer *t = tsd->curr_xfer;
-       unsigned long flags;
 
-       spin_lock_irqsave(&tsd->lock, flags);
+       spin_lock(&tsd->lock);
        if (tsd->tx_status || tsd->rx_status || (tsd->status_reg & SPI_BSY)) {
                dev_err(tsd->dev,
                        "CpuXfer ERROR bit set 0x%x\n", tsd->status_reg);
@@ -391,7 +390,7 @@ static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd)
        tegra_sflash_calculate_curr_xfer_param(tsd->cur_spi, tsd, t);
        tegra_sflash_start_cpu_based_transfer(tsd, t);
 exit:
-       spin_unlock_irqrestore(&tsd->lock, flags);
+       spin_unlock(&tsd->lock);
        return IRQ_HANDLED;
 }