media: saa7134: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 20 Nov 2020 18:37:08 +0000 (19:37 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 11:56:50 +0000 (12:56 +0100)
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
[hverkuil: fix checkpatch TAB indendation issues]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/saa7134/saa7134-tvaudio.c

index 5cc4ef2..aa0895d 100644 (file)
@@ -871,23 +871,24 @@ void saa7134_enable_i2s(struct saa7134_dev *dev)
        switch (dev->pci->device) {
        case PCI_DEVICE_ID_PHILIPS_SAA7133:
        case PCI_DEVICE_ID_PHILIPS_SAA7135:
-           /* Set I2S format (SONY)  */
-           saa_writeb(SAA7133_I2S_AUDIO_CONTROL, 0x00);
-           /* Start I2S */
-           saa_writeb(SAA7134_I2S_AUDIO_OUTPUT, 0x11);
-           break;
+               /* Set I2S format (SONY)  */
+               saa_writeb(SAA7133_I2S_AUDIO_CONTROL, 0x00);
+               /* Start I2S */
+               saa_writeb(SAA7134_I2S_AUDIO_OUTPUT, 0x11);
+               break;
 
        case PCI_DEVICE_ID_PHILIPS_SAA7134:
-           i2s_format = (dev->input->amux == TV) ? 0x00 : 0x01;
+               i2s_format = (dev->input->amux == TV) ? 0x00 : 0x01;
 
-           /* enable I2S audio output for the mpeg encoder */
-           saa_writeb(SAA7134_I2S_OUTPUT_SELECT, 0x80);
-           saa_writeb(SAA7134_I2S_OUTPUT_FORMAT, i2s_format);
-           saa_writeb(SAA7134_I2S_OUTPUT_LEVEL,  0x0F);
-           saa_writeb(SAA7134_I2S_AUDIO_OUTPUT,  0x01);
+               /* enable I2S audio output for the mpeg encoder */
+               saa_writeb(SAA7134_I2S_OUTPUT_SELECT, 0x80);
+               saa_writeb(SAA7134_I2S_OUTPUT_FORMAT, i2s_format);
+               saa_writeb(SAA7134_I2S_OUTPUT_LEVEL,  0x0F);
+               saa_writeb(SAA7134_I2S_AUDIO_OUTPUT,  0x01);
+               break;
 
        default:
-           break;
+               break;
        }
 }