crypto: qce - Add support to initialize interconnect path
authorThara Gopinath <thara.gopinath@gmail.com>
Wed, 22 Feb 2023 17:22:38 +0000 (19:22 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 14 Mar 2023 09:06:43 +0000 (17:06 +0800)
Crypto engine on certain Snapdragon processors like sm8150, sm8250, sm8350
etc. requires interconnect path between the engine and memory to be
explicitly enabled and bandwidth set prior to any operations. Add support
in the qce core to enable the interconnect path appropriately.

Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Thara Gopinath <thara.gopinath@gmail.com>
[Bhupesh: Make header file inclusion alphabetical and use devm_of_icc_get()]
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
[vladimir: moved icc bandwidth setup closer to its acquisition]
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qce/core.c
drivers/crypto/qce/core.h

index 74deca4..0654b94 100644 (file)
@@ -5,6 +5,7 @@
 
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
+#include <linux/interconnect.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
@@ -22,6 +23,8 @@
 #define QCE_MAJOR_VERSION5     0x05
 #define QCE_QUEUE_LENGTH       1
 
+#define QCE_DEFAULT_MEM_BANDWIDTH      393600
+
 static const struct qce_algo_ops *qce_ops[] = {
 #ifdef CONFIG_CRYPTO_DEV_QCE_SKCIPHER
        &skcipher_ops,
@@ -218,10 +221,18 @@ static int qce_crypto_probe(struct platform_device *pdev)
        if (IS_ERR(qce->bus))
                return PTR_ERR(qce->bus);
 
-       ret = clk_prepare_enable(qce->core);
+       qce->mem_path = devm_of_icc_get(qce->dev, "memory");
+       if (IS_ERR(qce->mem_path))
+               return PTR_ERR(qce->mem_path);
+
+       ret = icc_set_bw(qce->mem_path, QCE_DEFAULT_MEM_BANDWIDTH, QCE_DEFAULT_MEM_BANDWIDTH);
        if (ret)
                return ret;
 
+       ret = clk_prepare_enable(qce->core);
+       if (ret)
+               goto err_mem_path_disable;
+
        ret = clk_prepare_enable(qce->iface);
        if (ret)
                goto err_clks_core;
@@ -260,6 +271,9 @@ err_clks_iface:
        clk_disable_unprepare(qce->iface);
 err_clks_core:
        clk_disable_unprepare(qce->core);
+err_mem_path_disable:
+       icc_set_bw(qce->mem_path, 0, 0);
+
        return ret;
 }
 
index 085774c..228fcd6 100644 (file)
@@ -35,6 +35,7 @@ struct qce_device {
        void __iomem *base;
        struct device *dev;
        struct clk *core, *iface, *bus;
+       struct icc_path *mem_path;
        struct qce_dma_data dma;
        int burst_size;
        unsigned int pipe_pair_id;