Use lower case file name with #include
authorCarlo Bramini <30959007+carlo-bramini@users.noreply.github.com>
Mon, 1 Jul 2019 11:31:26 +0000 (13:31 +0200)
committerGitHub <noreply@github.com>
Mon, 1 Jul 2019 11:31:26 +0000 (13:31 +0200)
I tried to cross compile harfbuzz for Windows and an error was generated because `DWrite_1.h` was not found.
This happened because the filesystem is case sensitive and for this reason that include file was not found.
The right name of the file to be used is `dwrite_1.h`, with all letters not capitalized:
https://docs.microsoft.com/en-us/windows/desktop/api/dwrite_1/
I also verified in the installation of VS2017 with Windows Kit v10 and in that place it was also lower case.
So, in my opinion it should be better to change this.

src/hb-directwrite.cc

index 1f00aa4..1b2bd19 100644 (file)
@@ -28,7 +28,7 @@
 
 #include "hb-shaper-impl.hh"
 
-#include <DWrite_1.h>
+#include <dwrite_1.h>
 
 #include "hb-directwrite.h"