media: platform: sti: Fix runtime PM imbalance in regs_show
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 7 Apr 2021 05:43:13 +0000 (07:43 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 10:55:05 +0000 (12:55 +0200)
pm_runtime_get_sync() will increase the runtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sti/bdisp/bdisp-debug.c

index 2b27009..a27f638 100644 (file)
@@ -480,7 +480,7 @@ static int regs_show(struct seq_file *s, void *data)
        int ret;
        unsigned int i;
 
-       ret = pm_runtime_get_sync(bdisp->dev);
+       ret = pm_runtime_resume_and_get(bdisp->dev);
        if (ret < 0) {
                seq_puts(s, "Cannot wake up IP\n");
                return 0;