drm/gma500: Fix error return code in psb_driver_load()
authorJialin Zhang <zhangjialin11@huawei.com>
Mon, 30 Nov 2020 02:02:16 +0000 (10:02 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 1 Dec 2020 17:25:46 +0000 (18:25 +0100)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jialin Zhang <zhangjialin11@huawei.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201130020216.1906141-1-zhangjialin11@huawei.com
drivers/gpu/drm/gma500/psb_drv.c

index cc2d59e..134068f 100644 (file)
@@ -312,6 +312,8 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
        if (ret)
                goto out_err;
 
+       ret = -ENOMEM;
+
        dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0);
        if (!dev_priv->mmu)
                goto out_err;