media: cec-adap.c: log when claiming LA fails unexpectedly
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 13 May 2022 07:54:43 +0000 (08:54 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Jun 2022 09:30:30 +0000 (10:30 +0100)
If there is a hardware problem such as someone pulling the CEC line low
continuously, then the POLL message will fail with an error other than
OK, NACK, ABORTED or TIMEOUT. Log the tx_status value in that case to
help debug this.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/cec/core/cec-adap.c

index 8bf91b5..41a7929 100644 (file)
@@ -1309,8 +1309,11 @@ static int cec_config_log_addr(struct cec_adapter *adap,
         * we assume that something is really weird and that it is not a
         * good idea to try and claim this logical address.
         */
-       if (i == max_retries)
+       if (i == max_retries) {
+               dprintk(0, "polling for LA %u failed with tx_status=0x%04x\n",
+                       log_addr, msg.tx_status);
                return 0;
+       }
 
        /*
         * Message not acknowledged, so this logical