[media] v4l: ti-vpe: fix devm_ioremap_resource() return value checking
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 18 Mar 2014 10:41:42 +0000 (07:41 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 23 May 2014 15:14:49 +0000 (12:14 -0300)
devm_ioremap_resource() returns a pointer to the remapped memory or
an ERR_PTR() encoded error code on failure.  Fix the checks inside
csc_create() and sc_create() accordingly.

Cc: Archit Taneja <archit@ti.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tested-by: Archit Taneja<archit@ti.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/platform/ti-vpe/csc.c
drivers/media/platform/ti-vpe/sc.c

index acfea50..3374e04 100644 (file)
@@ -187,9 +187,9 @@ struct csc_data *csc_create(struct platform_device *pdev)
        }
 
        csc->base = devm_ioremap_resource(&pdev->dev, csc->res);
-       if (!csc->base) {
+       if (IS_ERR(csc->base)) {
                dev_err(&pdev->dev, "failed to ioremap\n");
-               return ERR_PTR(-ENOMEM);
+               return csc->base;
        }
 
        return csc;
index 93f0af5..6314171 100644 (file)
@@ -302,9 +302,9 @@ struct sc_data *sc_create(struct platform_device *pdev)
        }
 
        sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
-       if (!sc->base) {
+       if (IS_ERR(sc->base)) {
                dev_err(&pdev->dev, "failed to ioremap\n");
-               return ERR_PTR(-ENOMEM);
+               return sc->base;
        }
 
        return sc;