mips: cdmm: Fix refcount leak in mips_cdmm_phys_base
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 9 Mar 2022 09:17:10 +0000 (09:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:39 +0000 (14:23 +0200)
[ Upstream commit 4528668ca331f7ce5999b7746657b46db5b3b785 ]

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Fixes: 2121aa3e2312 ("mips: cdmm: Add mti,mips-cdmm dtb node support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bus/mips_cdmm.c

index 626dedd..fca0d06 100644 (file)
@@ -351,6 +351,7 @@ phys_addr_t __weak mips_cdmm_phys_base(void)
        np = of_find_compatible_node(NULL, NULL, "mti,mips-cdmm");
        if (np) {
                err = of_address_to_resource(np, 0, &res);
+               of_node_put(np);
                if (!err)
                        return res.start;
        }