perf intel-pt: decoder: Factor out clearing of FUP (Flow Update) event variables
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 24 Jan 2022 08:41:42 +0000 (10:41 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 15 Feb 2022 20:06:58 +0000 (17:06 -0300)
Factor out clearing of FUP (Flow Update) event variables, to avoid code duplication.

Committer Notes:

From the Intel documentation:

<quote>
Flow Update Packets (FUP): FUPs provide the source IP addresses for
asynchronous events (interrupt and exceptions), as well as other cases
where the source address cannot be determined from the binary.
</quote>

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20220124084201.2699795-7-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c

index 3980ee2..5792d53 100644 (file)
@@ -1206,6 +1206,16 @@ out_no_progress:
        return err;
 }
 
+static void intel_pt_clear_fup_event(struct intel_pt_decoder *decoder)
+{
+       decoder->set_fup_tx_flags = false;
+       decoder->set_fup_ptw = false;
+       decoder->set_fup_mwait = false;
+       decoder->set_fup_pwre = false;
+       decoder->set_fup_exstop = false;
+       decoder->set_fup_bep = false;
+}
+
 static bool intel_pt_fup_event(struct intel_pt_decoder *decoder)
 {
        enum intel_pt_sample_type type = decoder->state.type;
@@ -1623,12 +1633,7 @@ static int intel_pt_overflow(struct intel_pt_decoder *decoder)
        decoder->state.from_ip = decoder->ip;
        decoder->ip = 0;
        decoder->pge = false;
-       decoder->set_fup_tx_flags = false;
-       decoder->set_fup_ptw = false;
-       decoder->set_fup_mwait = false;
-       decoder->set_fup_pwre = false;
-       decoder->set_fup_exstop = false;
-       decoder->set_fup_bep = false;
+       intel_pt_clear_fup_event(decoder);
        decoder->overflow = true;
        return -EOVERFLOW;
 }
@@ -3518,12 +3523,7 @@ static int intel_pt_sync_ip(struct intel_pt_decoder *decoder)
 {
        int err;
 
-       decoder->set_fup_tx_flags = false;
-       decoder->set_fup_ptw = false;
-       decoder->set_fup_mwait = false;
-       decoder->set_fup_pwre = false;
-       decoder->set_fup_exstop = false;
-       decoder->set_fup_bep = false;
+       intel_pt_clear_fup_event(decoder);
        decoder->overflow = false;
 
        if (!decoder->branch_enable) {