Modify unnecessary LoadManifestData() function call

diff --git a/common/application_data.cc b/common/application_data.cc
index 7c59e75..19acc9a 100644 (file)
--- a/common/application_data.cc
+++ b/common/application_data.cc
@@ -82,7 +82,9 @@ static std::string GetPackageRootPath(const std::string& pkgid) {
 
 }  // namespace
 
-ApplicationData::ApplicationData(const std::string& appid) : app_id_(appid) {
+ApplicationData::ApplicationData(const std::string& appid)
+  : app_id_(appid),
+    loaded_(false) {
   pkg_id_ = GetPackageIdByAppId(appid);
   if (!pkg_id_.empty())
     application_path_ = GetPackageRootPath(pkg_id_) + kPathSeparator
@@ -179,7 +181,12 @@ ApplicationData::AppType ApplicationData::GetAppType() {
 }
 
 bool ApplicationData::LoadManifestData() {
+  if (loaded_) {
+    return true;
+  }
+
   SCOPE_PROFILE();
+
   std::string config_xml_path(application_path_ + kConfigXml);
   if (!utils::Exists(config_xml_path)) {
     LOGGER(ERROR) << "Failed to load manifest data : No such file '"
@@ -270,6 +277,8 @@ bool ApplicationData::LoadManifestData() {
 
   app_type_ = GetAppType();
 
+  loaded_ = true;
+
   return true;
 }
 

diff --git a/common/application_data.h b/common/application_data.h
index f8c2eba..4f196cd 100644 (file)
--- a/common/application_data.h
+++ b/common/application_data.h
@@ -121,6 +121,7 @@ class ApplicationData {
   std::string pkg_id_;
   std::string app_id_;
   ApplicationData::AppType app_type_;
+  bool loaded_;
 };