PREVENT 473451, 474214 : Fixed the code generating memory leak

Change-Id: I9b00d76ae8a40606604dd0009a7c41b6e5d3e37a
Signed-off-by: Hyojung Jo <hj903.jo@samsung.com>

diff --git a/src/data/app.c b/src/data/app.c
index 6601d40..62135dc 100644 (file)
--- a/src/data/app.c
+++ b/src/data/app.c
@@ -70,15 +70,16 @@ static void _app_favorite_list_foreach(gpointer data, gpointer user_data)
 
        if (id)
                adata->id = strdup(id);
-       if (name)
-               adata->name = strdup(name);
-       if (icon)
-               adata->icon = strdup(icon);
 
        /* FIXME: The browser's name and icon is defined as GUI. */
        if (!strcmp(id, APP_ID_BROWSER)) {
-               adata->name = STR_BROWSER;
-               adata->icon = BROWSER_ICON_PNG;
+               adata->name = strdup(STR_BROWSER);
+               adata->icon = strdup(BROWSER_ICON_PNG);
+       } else {
+               if (name)
+                       adata->name = strdup(name);
+               if (icon)
+                       adata->icon = strdup(icon);
        }
 
        *l = eina_list_append(*l, adata);