leds: lt3593: Use generic support for composing LED names
authorJacek Anaszewski <jacek.anaszewski@gmail.com>
Sun, 9 Jun 2019 18:19:04 +0000 (20:19 +0200)
committerJacek Anaszewski <jacek.anaszewski@gmail.com>
Thu, 25 Jul 2019 18:07:54 +0000 (20:07 +0200)
Switch to using generic LED support for composing LED class
device name.

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Daniel Mack <daniel@zonque.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-lt3593.c

index 83e8e58..c94995f 100644 (file)
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <uapi/linux/uleds.h>
+
+#define LED_LT3593_NAME "lt3593"
 
 struct lt3593_led_data {
-       char name[LED_MAX_NAME_SIZE];
        struct led_classdev cdev;
        struct gpio_desc *gpiod;
 };
@@ -66,6 +66,7 @@ static int lt3593_led_probe(struct platform_device *pdev)
        struct lt3593_led_data *led_data;
        struct fwnode_handle *child;
        int ret, state = LEDS_GPIO_DEFSTATE_OFF;
+       struct led_init_data init_data = {};
        const char *tmp;
 
        if (!dev->of_node)
@@ -86,14 +87,6 @@ static int lt3593_led_probe(struct platform_device *pdev)
 
        child = device_get_next_child_node(dev, NULL);
 
-       ret = fwnode_property_read_string(child, "label", &tmp);
-       if (ret < 0)
-               snprintf(led_data->name, sizeof(led_data->name),
-                        "lt3593::");
-       else
-               snprintf(led_data->name, sizeof(led_data->name),
-                        "lt3593:%s", tmp);
-
        fwnode_property_read_string(child, "linux,default-trigger",
                                    &led_data->cdev.default_trigger);
 
@@ -102,11 +95,14 @@ static int lt3593_led_probe(struct platform_device *pdev)
                        state = LEDS_GPIO_DEFSTATE_ON;
        }
 
-       led_data->cdev.name = led_data->name;
        led_data->cdev.brightness_set_blocking = lt3593_led_set;
        led_data->cdev.brightness = state ? LED_FULL : LED_OFF;
 
-       ret = devm_led_classdev_register(dev, &led_data->cdev);
+       init_data.fwnode = child;
+       init_data.devicename = LED_LT3593_NAME;
+       init_data.default_label = ":";
+
+       ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data);
        if (ret < 0) {
                fwnode_handle_put(child);
                return ret;