scsi: iscsi: Do not put host in iscsi_set_flashnode_param()
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Mon, 15 Jun 2020 08:12:26 +0000 (16:12 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 29 Jul 2020 02:56:24 +0000 (22:56 -0400)
If scsi_host_lookup() fails we will jump to put_host which may cause a
panic. Jump to exit_set_fnode instead.

Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_iscsi.c

index 6c6c8786e22f58a6f54cf4586dd4b9acfdb6a162..bb53cdea79b6fc1d6a07a61b3f82051a66508e7f 100644 (file)
@@ -3290,7 +3290,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
                pr_err("%s could not find host no %u\n",
                       __func__, ev->u.set_flashnode.host_no);
                err = -ENODEV;
-               goto put_host;
+               goto exit_set_fnode;
        }
 
        idx = ev->u.set_flashnode.flashnode_idx;