media: si21xx: report eventual errors at set_frontend

If an error occurs while setting the registers at set_frontend,
it is silently ignored. Yet, the variable status is updated.

Change the logic to return an error if it fails to write values
to the registers.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/dvb-frontends/si21xx.c b/drivers/media/dvb-frontends/si21xx.c
index e31eb2c..001b235 100644 (file)
--- a/drivers/media/dvb-frontends/si21xx.c
+++ b/drivers/media/dvb-frontends/si21xx.c
@@ -711,7 +711,7 @@ static int si21xx_set_frontend(struct dvb_frontend *fe)
        int i;
        bool inband_interferer_div2[ALLOWABLE_FS_COUNT];
        bool inband_interferer_div4[ALLOWABLE_FS_COUNT];
-       int status;
+       int status = 0;
 
        /* allowable sample rates for ADC in MHz */
        int afs[ALLOWABLE_FS_COUNT] = { 200, 192, 193, 194, 195,
@@ -747,8 +747,6 @@ static int si21xx_set_frontend(struct dvb_frontend *fe)
        rf_freq = 10 * c->frequency ;
        data_rate = c->symbol_rate / 100;
 
-       status = PASS;
-
        band_low = (rf_freq - lnb_lo) - ((lnb_uncertanity * 200)
                                        + (data_rate * 135)) / 200;
 
@@ -832,6 +830,9 @@ static int si21xx_set_frontend(struct dvb_frontend *fe)
        state->fs = sample_rate;/*ADC MHz*/
        si21xx_setacquire(fe, c->symbol_rate, c->fec_inner);
 
+       if (status)
+               return -EREMOTEIO;
+
        return 0;
 }