drm/i915/selftests: Set error returns
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 4 Jan 2021 11:51:40 +0000 (11:51 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 5 Jan 2021 09:14:41 +0000 (09:14 +0000)
A few missed PTR_ERR() upon create_gang() errors.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210104115145.24460-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/selftest_execlists.c

index 080b630..3854da5 100644 (file)
@@ -2658,8 +2658,10 @@ static int create_gang(struct intel_engine_cs *engine,
                goto err_obj;
 
        cs = i915_gem_object_pin_map(obj, I915_MAP_WC);
-       if (IS_ERR(cs))
+       if (IS_ERR(cs)) {
+               err = PTR_ERR(cs);
                goto err_obj;
+       }
 
        /* Semaphore target: spin until zero */
        *cs++ = MI_ARB_ON_OFF | MI_ARB_ENABLE;
@@ -2686,8 +2688,10 @@ static int create_gang(struct intel_engine_cs *engine,
        i915_gem_object_unpin_map(obj);
 
        rq = intel_context_create_request(ce);
-       if (IS_ERR(rq))
+       if (IS_ERR(rq)) {
+               err = PTR_ERR(rq);
                goto err_obj;
+       }
 
        rq->batch = i915_vma_get(vma);
        i915_request_get(rq);