move v8_use_external_startup_data to standalone.gypi
authormostynb <mostynb@opera.com>
Thu, 11 Dec 2014 15:27:38 +0000 (07:27 -0800)
committerCommit bot <commit-bot@chromium.org>
Thu, 11 Dec 2014 15:27:44 +0000 (15:27 +0000)
This allows the setting to be overridable by embedders,
at the cost of forcing embedders that don't build v8
using standalone.gypi to add this setting to their build
config.

BUG=chromium:421063
LOG=Y

Review URL: https://codereview.chromium.org/794583002

Cr-Commit-Position: refs/heads/master@{#25781}

build/features.gypi
build/standalone.gypi

index c5b7c42..25041ce 100644 (file)
     # Enable compiler warnings when using V8_DEPRECATED apis.
     'v8_deprecation_warnings%': 0,
 
-    # Use external files for startup data blobs:
-    # the JS builtins sources and the start snapshot.
-    'v8_use_external_startup_data%': 0,
-
     # Set to 1 to enable DCHECKs in release builds.
     'dcheck_always_on%': 0,
   },
index 76fa719..f618a06 100644 (file)
     #     near-release speeds.
     'v8_optimized_debug%': 0,
 
+    # Use external files for startup data blobs:
+    # the JS builtins sources and the start snapshot.
+    # Embedders that don't use standalone.gypi will need to add
+    # their own default value.
+    'v8_use_external_startup_data%': 0,
+
     # Relative path to icu.gyp from this file.
     'icu_gyp_path': '../third_party/icu/icu.gyp',