applicom: fix some err codes returned by ac_ioctl
authorXu Jia <xujia39@huawei.com>
Wed, 24 Mar 2021 07:20:31 +0000 (15:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Mar 2021 12:50:49 +0000 (14:50 +0200)
When cmd > 6 or copy_to_user() fail, The variable 'ret' would not be
returned back. Fix the 'ret' set but not used.

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Xu Jia <xujia39@huawei.com>
Link: https://lore.kernel.org/r/20210324072031.941791-1-xujia39@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/applicom.c

index 14b2d80..0ab7651 100644 (file)
@@ -839,7 +839,7 @@ static long ac_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        Dummy = readb(apbs[IndexCard].RamIO + VERS);
        kfree(adgl);
        mutex_unlock(&ac_mutex);
-       return 0;
+       return ret;
 
 err:
        if (warncount) {