iio: adc: at91-sama5d2_adc: Use dma_request_chan() instead dma_request_slave_channel()
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Tue, 7 Jan 2020 11:37:29 +0000 (13:37 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 12 Jan 2020 11:34:11 +0000 (11:34 +0000)
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

The dma_request_chan() is the standard API to request slave channel,
clients should be moved away from the legacy API to allow us to retire
them.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/at91-sama5d2_adc.c

index e1850f3..a5c7771 100644 (file)
@@ -1444,10 +1444,10 @@ static void at91_adc_dma_init(struct platform_device *pdev)
        if (st->dma_st.dma_chan)
                return;
 
-       st->dma_st.dma_chan = dma_request_slave_channel(&pdev->dev, "rx");
-
-       if (!st->dma_st.dma_chan)  {
+       st->dma_st.dma_chan = dma_request_chan(&pdev->dev, "rx");
+       if (IS_ERR(st->dma_st.dma_chan))  {
                dev_info(&pdev->dev, "can't get DMA channel\n");
+               st->dma_st.dma_chan = NULL;
                goto dma_exit;
        }