[NFC] Mark derived destructors as `override`
authorAntonio Frighetto <me@antoniofrighetto.com>
Thu, 24 Mar 2022 10:42:47 +0000 (11:42 +0100)
committerNikita Popov <npopov@redhat.com>
Thu, 24 Mar 2022 10:42:47 +0000 (11:42 +0100)
Derived destructors can be marked as override, in order to prevent
possible compilation failures of projects depending on those
headers (when compiled with flags -Wall, -Wsuggest-destructor-override,
-Winconsistent-missing-destructor-override).

Differential Revision: https://reviews.llvm.org/D121993

llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
llvm/include/llvm/IR/IRBuilder.h

index c4e04f362114ef4acaf3a6e62f4c590b5f0b7a00..9749cb9cd059afc0838d06248e2b30404b858415 100644 (file)
@@ -118,7 +118,7 @@ public:
                    WithColor::defaultErrorHandler,
                std::function<void(Error)> WarningHandler =
                    WithColor::defaultWarningHandler);
-  ~DWARFContext();
+  ~DWARFContext() override;
 
   DWARFContext(DWARFContext &) = delete;
   DWARFContext &operator=(DWARFContext &) = delete;
index c28ccaa789a850f2465469a0964de9984ce991aa..7e26d3504e05339f7c11d3d49ab89facc1151c92 100644 (file)
@@ -77,7 +77,7 @@ class IRBuilderCallbackInserter : public IRBuilderDefaultInserter {
   std::function<void(Instruction *)> Callback;
 
 public:
-  virtual ~IRBuilderCallbackInserter();
+  ~IRBuilderCallbackInserter() override;
 
   IRBuilderCallbackInserter(std::function<void(Instruction *)> Callback)
       : Callback(std::move(Callback)) {}