d3d12: Only destroy the winsys during screen destruction, not reset
authorJesse Natalie <jenatali@microsoft.com>
Mon, 18 Dec 2023 18:44:25 +0000 (10:44 -0800)
committerEric Engestrom <eric@engestrom.ch>
Wed, 20 Dec 2023 00:05:01 +0000 (00:05 +0000)
Fixes: 81c8e89f ("d3d12: Fix screen->winsys leak in d3d12_screen")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26744>
(cherry picked from commit 325fb6e26b62326c86514d263ffedd241fd36865)

.pick_status.json
src/gallium/drivers/d3d12/d3d12_screen.cpp

index a6307c1..2056ada 100644 (file)
         "description": "d3d12: Only destroy the winsys during screen destruction, not reset",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "81c8e89ff8e846839fffc1d103b2080bef5c1b5c",
         "notes": null
index ee74cf2..9b0233f 100644 (file)
@@ -735,15 +735,15 @@ d3d12_deinit_screen(struct d3d12_screen *screen)
       screen->dev->Release();
       screen->dev = nullptr;
    }
-   if (screen->winsys) {
-      screen->winsys->destroy(screen->winsys);
-      screen->winsys = nullptr;
-   }
 }
 
 void
 d3d12_destroy_screen(struct d3d12_screen *screen)
 {
+   if (screen->winsys) {
+      screen->winsys->destroy(screen->winsys);
+      screen->winsys = nullptr;
+   }
    slab_destroy_parent(&screen->transfer_pool);
    mtx_destroy(&screen->submit_mutex);
    mtx_destroy(&screen->descriptor_pool_mutex);