Only S_OK hresult from GetModuleMetaData() guarantees return of valid pointer
authorAleksei Vereshchagin <avereschagin@dev.rtsoft.ru>
Mon, 11 Dec 2017 17:19:28 +0000 (20:19 +0300)
committerAleksei Vereshchagin <avereschagin@dev.rtsoft.ru>
Mon, 11 Dec 2017 17:19:28 +0000 (20:19 +0300)
src/info/classinfo.cpp
src/info/functioninfo.cpp

index 1a40b23..bd603cc 100644 (file)
@@ -367,7 +367,7 @@ __forceinline HRESULT ClassInfo::InitializeRegularClassName(
         hr = info.v1()->GetModuleMetaData(
             this->moduleId, ofRead, IID_IMetaDataImport,
             reinterpret_cast<IUnknown**>(&pMDImport));
-        if (FAILED(hr))
+        if (hr != S_OK)
         {
             throw HresultException(
                 "ClassInfo::InitializeRegularClassName(): "
index 1cf211c..65e370b 100644 (file)
@@ -793,7 +793,7 @@ HRESULT FunctionInfo::Initialize(
         hr = info.v1()->GetModuleMetaData(
             this->moduleId, ofRead, IID_IMetaDataImport,
             reinterpret_cast<IUnknown**>(&pMDImport));
-        if (FAILED(hr))
+        if (hr != S_OK)
         {
             throw HresultException(
                 "FunctionInfo::Initialize(): GetModuleMetaData()", hr);