habanalabs/gaudi2: added memset for the cq_size register
authorMarco Pagani <marpagan@redhat.com>
Wed, 23 Nov 2022 08:56:39 +0000 (09:56 +0100)
committerOded Gabbay <ogabbay@kernel.org>
Wed, 23 Nov 2022 14:22:38 +0000 (16:22 +0200)
The clang-analyzer reported a warning: "Value stored to
'cq_size_addr' is never read".

The cq_size register of dcore0 is not being zeroed using
gaudi2_memset_device_lbw(), along with the other cq_* registers,
even though the corresponding cq_size_addr variable is set.

Signed-off-by: Marco Pagani <marpagan@redhat.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/gaudi2/gaudi2.c

index c14e631..a33a907 100644 (file)
@@ -9386,6 +9386,7 @@ static void gaudi2_restore_user_sm_registers(struct hl_device *hdev)
        gaudi2_memset_device_lbw(hdev, cq_lbw_data_addr, size, 0);
        gaudi2_memset_device_lbw(hdev, cq_base_l_addr, size, 0);
        gaudi2_memset_device_lbw(hdev, cq_base_h_addr, size, 0);
+       gaudi2_memset_device_lbw(hdev, cq_size_addr, size, 0);
 
        cq_lbw_l_addr = mmDCORE0_SYNC_MNGR_GLBL_LBW_ADDR_L_0 + DCORE_OFFSET;
        cq_lbw_h_addr = mmDCORE0_SYNC_MNGR_GLBL_LBW_ADDR_H_0 + DCORE_OFFSET;