media: sun8i: Remove redundant platform_get_irq error message
authorYueHaibing <yuehaibing@huawei.com>
Thu, 16 Jan 2020 14:36:30 +0000 (15:36 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 24 Feb 2020 16:14:33 +0000 (17:14 +0100)
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sunxi/sun8i-di/sun8i-di.c

index 2145673..d78f659 100644 (file)
@@ -814,11 +814,8 @@ static int deinterlace_probe(struct platform_device *pdev)
        dev->dev = &pdev->dev;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               dev_err(dev->dev, "Failed to get IRQ\n");
-
+       if (irq <= 0)
                return irq;
-       }
 
        ret = devm_request_irq(dev->dev, irq, deinterlace_irq,
                               0, dev_name(dev->dev), dev);