perf tools: Add fake_pmu to parse_group() function
authorJiri Olsa <jolsa@kernel.org>
Tue, 9 Jun 2020 15:50:42 +0000 (12:50 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 22 Jun 2020 19:28:08 +0000 (16:28 -0300)
Allow to pass fake_pmu in parse_groups function so it can be used in
parse_events call.

It's will be passed by the upcoming metricgroup__parse_groups_test
function.

Committer notes:

Made it a 'struct perf_pmu' pointer, in line with the changes at the
start of this patchkit to avoid statics deep down in library code.

Acked-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20200602214741.1218986-6-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/metricgroup.c

index d72a565..49e6f7c 100644 (file)
@@ -712,6 +712,7 @@ static void metricgroup__free_egroups(struct list_head *group_list)
 static int parse_groups(struct evlist *perf_evlist, const char *str,
                        bool metric_no_group,
                        bool metric_no_merge,
+                       struct perf_pmu *fake_pmu,
                        struct rblist *metric_events)
 {
        struct parse_events_error parse_error;
@@ -727,7 +728,7 @@ static int parse_groups(struct evlist *perf_evlist, const char *str,
                return ret;
        pr_debug("adding %s\n", extra_events.buf);
        bzero(&parse_error, sizeof(parse_error));
-       ret = parse_events(perf_evlist, extra_events.buf, &parse_error);
+       ret = __parse_events(perf_evlist, extra_events.buf, &parse_error, fake_pmu);
        if (ret) {
                parse_events_print_error(&parse_error, extra_events.buf);
                goto out;
@@ -749,7 +750,7 @@ int metricgroup__parse_groups(const struct option *opt,
        struct evlist *perf_evlist = *(struct evlist **)opt->value;
 
        return parse_groups(perf_evlist, str, metric_no_group,
-                           metric_no_merge, metric_events);
+                           metric_no_merge, NULL, metric_events);
 }
 
 bool metricgroup__has_metric(const char *metric)