bus: moxtet: fix unsigned comparison to less than zero
authorColin Ian King <colin.king@canonical.com>
Thu, 22 Aug 2019 01:03:50 +0000 (03:03 +0200)
committerArnd Bergmann <arnd@arndb.de>
Wed, 4 Sep 2019 15:30:16 +0000 (17:30 +0200)
Currently the size_t variable res is being checked for
an error failure however the unsigned variable is never
less than zero so this test is always false. Fix this by
making variable res ssize_t

Link: https://lore.kernel.org/r/20190822010351.15660-2-marek.behun@nic.cz
Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 5bc7f990cd98 ("bus: Add support for Moxtet bus")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marek BehĂșn <marek.behun@nic.cz>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/bus/moxtet.c

index baccf76..36cf13e 100644 (file)
@@ -514,7 +514,7 @@ static ssize_t output_write(struct file *file, const char __user *buf,
        struct moxtet *moxtet = file->private_data;
        u8 bin[TURRIS_MOX_MAX_MODULES];
        u8 hex[sizeof(bin) * 2 + 1];
-       size_t res;
+       ssize_t res;
        loff_t dummy = 0;
        int err, i;