elm dbus menu - handle return value of eldbus_message_iter_arguments_get 51/153251/2
authorHosang Kim <hosang12.kim@samsung.com>
Thu, 28 Sep 2017 06:40:44 +0000 (15:40 +0900)
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>
Thu, 28 Sep 2017 06:51:11 +0000 (06:51 +0000)
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.

Change-Id: I213f644c6450e550f5a26fd9a0c11a707d71f94a

src/lib/elm_dbus_menu.c

index f850cae..af79350 100644 (file)
@@ -401,8 +401,9 @@ _event_handle(Elm_DBus_Menu *dbus_menu, Eldbus_Message_Iter *iter, int *error_id
    Eldbus_Message_Iter *data;
    unsigned *timestamp;
 
-   eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data,
-                                    &timestamp);
+   if (!eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data,
+                                          &timestamp))
+     return EINA_FALSE;
    i = id;
    item = eina_hash_find(dbus_menu->elements, &i);
    if (!item)