mt76: mt7921: fix endianness warnings in mt7921_mac_decode_he_mu_radiotap
authorLorenzo Bianconi <lorenzo@kernel.org>
Fri, 13 Aug 2021 11:26:53 +0000 (13:26 +0200)
committerFelix Fietkau <nbd@nbd.name>
Wed, 20 Oct 2021 08:36:35 +0000 (10:36 +0200)
Fix the following sparse endianness warnings

drivers/net/wireless/mediatek/mt76/mt7921/mac.c:212:28: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:212:28: warning: cast to restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:212:28: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:212:28: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:212:28: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:217:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:217:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:217:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:217:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:222:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:222:25: warning: cast to restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:222:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:222:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:222:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:224:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:224:25: warning: cast to restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:224:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:224:25: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:224:25: warning: restricted __le32 degrades to integer
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:259:13: warning: cast from restricted __le32
drivers/net/wireless/mediatek/mt76/mt7921/mac.c:259:13: warning: restricted __le32 degrades to integer

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7921/mac.c

index 1e845ad..7425d57 100644 (file)
@@ -194,7 +194,7 @@ mt7921_mac_decode_he_mu_radiotap(struct sk_buff *skb,
                .flags2 = HE_BITS(MU_FLAGS2_BW_FROM_SIG_A_BW_KNOWN) |
                          HE_BITS(MU_FLAGS2_PUNC_FROM_SIG_A_BW_KNOWN),
        };
-       struct ieee80211_radiotap_he_mu *he_mu = NULL;
+       struct ieee80211_radiotap_he_mu *he_mu;
 
        he_mu = skb_push(skb, sizeof(mu_known));
        memcpy(he_mu, &mu_known, sizeof(mu_known));
@@ -209,19 +209,19 @@ mt7921_mac_decode_he_mu_radiotap(struct sk_buff *skb,
                         MU_PREP(FLAGS2_SIG_B_SYMS_USERS,
                                 le32_get_bits(rxv[2], MT_CRXV_HE_NUM_USER));
 
-       he_mu->ru_ch1[0] = FIELD_GET(MT_CRXV_HE_RU0, cpu_to_le32(rxv[3]));
+       he_mu->ru_ch1[0] = FIELD_GET(MT_CRXV_HE_RU0, le32_to_cpu(rxv[3]));
 
        if (status->bw >= RATE_INFO_BW_40) {
                he_mu->flags1 |= HE_BITS(MU_FLAGS1_CH2_RU_KNOWN);
                he_mu->ru_ch2[0] =
-                       FIELD_GET(MT_CRXV_HE_RU1, cpu_to_le32(rxv[3]));
+                       FIELD_GET(MT_CRXV_HE_RU1, le32_to_cpu(rxv[3]));
        }
 
        if (status->bw >= RATE_INFO_BW_80) {
                he_mu->ru_ch1[1] =
-                       FIELD_GET(MT_CRXV_HE_RU2, cpu_to_le32(rxv[3]));
+                       FIELD_GET(MT_CRXV_HE_RU2, le32_to_cpu(rxv[3]));
                he_mu->ru_ch2[1] =
-                       FIELD_GET(MT_CRXV_HE_RU3, cpu_to_le32(rxv[3]));
+                       FIELD_GET(MT_CRXV_HE_RU3, le32_to_cpu(rxv[3]));
        }
 }
 
@@ -256,7 +256,7 @@ mt7921_mac_decode_he_radiotap(struct sk_buff *skb,
        he->data5 = HE_PREP(DATA5_PE_DISAMBIG, PE_DISAMBIG, rxv[2]) |
                    le16_encode_bits(ltf_size,
                                     IEEE80211_RADIOTAP_HE_DATA5_LTF_SIZE);
-       if (cpu_to_le32(rxv[0]) & MT_PRXV_TXBF)
+       if (le32_to_cpu(rxv[0]) & MT_PRXV_TXBF)
                he->data5 |= HE_BITS(DATA5_TXBF);
        he->data6 = HE_PREP(DATA6_TXOP, TXOP_DUR, rxv[14]) |
                    HE_PREP(DATA6_DOPPLER, DOPPLER, rxv[14]);