ethernet: clean the coverity errors of eth module

PD#166793: code defects in eth part

Change-Id: I5e9a4bc9ff3c89a2fff8fa000d2c33dc87f2492c
Signed-off-by: qi duan <qi.duan@amlogic.com>

diff --git a/drivers/amlogic/ethernet/phy/amlogic.c b/drivers/amlogic/ethernet/phy/amlogic.c
index ff88ee7..00f4152 100644 (file)
--- a/drivers/amlogic/ethernet/phy/amlogic.c
+++ b/drivers/amlogic/ethernet/phy/amlogic.c
@@ -178,7 +178,7 @@ static int internal_phy_read_status(struct phy_device *phydev)
                /*read internal phy reg 0x1f*/
                reg31 = phy_read(phydev, 0x1f);
                /*bit 12 auto negotiation done*/
-               if (reg31 | 0x1000) {
+               if (reg31 & 0x1000) {
                        phydev->pause = 0;
                        phydev->asym_pause = 0;
                        phydev->speed = SPEED_10;

diff --git a/drivers/amlogic/ethernet/phy/phy_debug.c b/drivers/amlogic/ethernet/phy/phy_debug.c
index ee7ebba..fa22fc3 100644 (file)
--- a/drivers/amlogic/ethernet/phy/phy_debug.c
+++ b/drivers/amlogic/ethernet/phy/phy_debug.c
@@ -890,7 +890,7 @@ static ssize_t eth_cali_store(
                pr_err("Sorry ,this cpu is not support cali!\n");
                goto end;
        }
-       for (argc = 0; argc < 6; argc++) {
+       for (argc = 0; argc < 5; argc++) {
                para = strsep(&p, " ");
                if (!para)
                        break;