[include-cleaner] Ignore the layering-violation errors for the standalone tool
authorHaojian Wu <hokein.wu@gmail.com>
Wed, 5 Jul 2023 07:29:11 +0000 (09:29 +0200)
committerHaojian Wu <hokein.wu@gmail.com>
Wed, 5 Jul 2023 11:30:26 +0000 (13:30 +0200)
If the source code is compilable-but-layering-violation, we still want
the tool to be functional on it (rather than bailing out).

Differential Revision: https://reviews.llvm.org/D154477

clang-tools-extra/include-cleaner/test/Inputs/modules/a.h [new file with mode: 0644]
clang-tools-extra/include-cleaner/test/Inputs/modules/module.map [new file with mode: 0644]
clang-tools-extra/include-cleaner/test/module.cpp [new file with mode: 0644]
clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp

diff --git a/clang-tools-extra/include-cleaner/test/Inputs/modules/a.h b/clang-tools-extra/include-cleaner/test/Inputs/modules/a.h
new file mode 100644 (file)
index 0000000..0b502e2
--- /dev/null
@@ -0,0 +1,2 @@
+#pragma once
+class A {};
diff --git a/clang-tools-extra/include-cleaner/test/Inputs/modules/module.map b/clang-tools-extra/include-cleaner/test/Inputs/modules/module.map
new file mode 100644 (file)
index 0000000..510bfdb
--- /dev/null
@@ -0,0 +1,2 @@
+module XA {
+}
diff --git a/clang-tools-extra/include-cleaner/test/module.cpp b/clang-tools-extra/include-cleaner/test/module.cpp
new file mode 100644 (file)
index 0000000..b344d16
--- /dev/null
@@ -0,0 +1,7 @@
+// RUN: cp %s %t.cpp
+// RUN: clang-include-cleaner -edit %t.cpp -- -I%S/Inputs/modules -fimplicit-module-maps -fmodules-strict-decluse -fmodule-name=XA
+// RUN: FileCheck --match-full-lines --check-prefix=EDIT %s < %t.cpp
+
+// Verify the tool still works on compilable-but-layering-violation code.
+#include "a.h"
+// EDIT-NOT: {{^}}#include "a.h"{{$}}
index 574023f..62febb4 100644 (file)
@@ -95,6 +95,15 @@ class Action : public clang::ASTFrontendAction {
   RecordedPP PP;
   PragmaIncludes PI;
 
+  bool BeginInvocation(CompilerInstance &CI) override {
+    // We only perform include-cleaner analysis. So we disable diagnostics that
+    // won't affect our analysis to make the tool more robust against
+    // in-development code.
+    CI.getLangOpts().ModulesDeclUse = false;
+    CI.getLangOpts().ModulesStrictDeclUse = false;
+    return true;
+  }
+
   void ExecuteAction() override {
     auto &P = getCompilerInstance().getPreprocessor();
     P.addPPCallbacks(PP.record(P));