A nested class in a member function can erroneously confuse the check into
thinking that any CXXThisExpr found relate to the outer class, preventing any warnings.
Fix this by not traversing any nested classes.
Fixes https://github.com/llvm/llvm-project/issues/56765
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D130665
Used = true;
return false; // Stop traversal.
}
+
+ // If we enter a class declaration, don't traverse into it as any usages of
+ // `this` will correspond to the nested class.
+ bool TraverseCXXRecordDecl(CXXRecordDecl *RD) { return true; }
+
} UsageOfThis;
// TraverseStmt does not modify its argument.
``std::array`` objects to default constructed ones. The behavior for this and
other relevant classes can now be configured with a new option.
+- Fixed a false negative in :doc:`readability-convert-member-functions-to-static
+ <clang-tidy/checks/readability/convert-member-functions-to-static>` when a
+ nested class in a member function uses a ``this`` pointer.
+
- Fixed reading `HungarianNotation.CString.*` options in
:doc:`readability-identifier-naming
<clang-tidy/checks/readability/identifier-naming>` check.
static_field = 1;
}
+ void static_nested() {
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: method 'static_nested' can be made static
+ // CHECK-FIXES: {{^}} static void static_nested() {
+ struct Nested {
+ int Foo;
+ int getFoo() { return Foo; }
+ };
+ }
+
+ void write_nested() {
+ struct Nested {
+ int Foo;
+ int getFoo() { return Foo; }
+ };
+ // Ensure we still detect usages of `this` once we leave the nested class definition.
+ field = 1;
+ }
+
static int already_static() { return static_field; }
int already_const() const { return field; }