HSI: core: Use kcalloc() in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 25 Apr 2017 12:17:50 +0000 (14:17 +0200)
committerSebastian Reichel <sre@kernel.org>
Thu, 8 Jun 2017 11:21:43 +0000 (13:21 +0200)
Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/hsi/hsi_core.c

index c2a2a97..9065efd 100644 (file)
@@ -267,14 +267,13 @@ static void hsi_add_client_from_dt(struct hsi_port *port,
 
        cl->rx_cfg.num_channels = cells;
        cl->tx_cfg.num_channels = cells;
-
-       cl->rx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL);
+       cl->rx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL);
        if (!cl->rx_cfg.channels) {
                err = -ENOMEM;
                goto err;
        }
 
-       cl->tx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL);
+       cl->tx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL);
        if (!cl->tx_cfg.channels) {
                err = -ENOMEM;
                goto err2;
@@ -485,7 +484,7 @@ struct hsi_controller *hsi_alloc_controller(unsigned int n_ports, gfp_t flags)
        hsi = kzalloc(sizeof(*hsi), flags);
        if (!hsi)
                return NULL;
-       port = kzalloc(sizeof(*port)*n_ports, flags);
+       port = kcalloc(n_ports, sizeof(*port), flags);
        if (!port) {
                kfree(hsi);
                return NULL;