media: s5p-mfc: use pm_runtime_resume_and_get()
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 23 Apr 2021 15:19:20 +0000 (17:19 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 20 May 2021 14:02:43 +0000 (16:02 +0200)
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c

index 62d2320..88b7d33 100644 (file)
@@ -78,11 +78,9 @@ int s5p_mfc_power_on(void)
 {
        int i, ret = 0;
 
-       ret = pm_runtime_get_sync(pm->device);
-       if (ret < 0) {
-               pm_runtime_put_noidle(pm->device);
+       ret = pm_runtime_resume_and_get(pm->device);
+       if (ret < 0)
                return ret;
-       }
 
        /* clock control */
        for (i = 0; i < pm->num_clocks; i++) {