usb: gadget: at91_udc: Remove unneeded variable

at91_wakeup is always returning -EINVAL.

But usb_gadget_wakeup expects 0 on success and negative number on
failure. As per current implementation this function wont fail.

This patch removes unneeded variable and returns 0.

Issue identified by coccicheck

drivers/usb/gadget/udc/at91_udc.c:802:6-12:
Unneeded variable: "status". Return "- EINVAL" on line 821

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 03959dc86cfd86f08e6eb1d83ccf3cd6eea5aa84..194ffb1ed462094593b334970533f5ccfd24f22a 100644 (file)
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -799,7 +799,6 @@ static int at91_wakeup(struct usb_gadget *gadget)
 {
        struct at91_udc *udc = to_udc(gadget);
        u32             glbstate;
-       int             status = -EINVAL;
        unsigned long   flags;
 
        DBG("%s\n", __func__ );
@@ -818,7 +817,7 @@ static int at91_wakeup(struct usb_gadget *gadget)
 
 done:
        spin_unlock_irqrestore(&udc->lock, flags);
-       return status;
+       return 0;
 }
 
 /* reinit == restore initial software state */